perf: static bootstrap options in snapshot #21213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 15, 2023
Comment on lines
+359
to
+365
| fn deno_version() -> String { | ||
| if env::var("DENO_CANARY").is_ok() { | ||
| format!("{}+{}", env!("CARGO_PKG_VERSION"), git_commit_hash()) | ||
| } else { | ||
| env!("CARGO_PKG_VERSION").to_string() | ||
| } | ||
| } |
There was a problem hiding this comment.
Isn't this duplicated in cli/version.rs? Could we maybe reuse some of the code?
There was a problem hiding this comment.
env!(DENO_CANARY) macro won't work from build.rs
| @@ -476,7 +476,7 @@ impl WebWorker { | |||
| ops::signal::deno_signal::init_ops_and_esm(), | |||
| ops::tty::deno_tty::init_ops_and_esm(), | |||
| ops::http::deno_http_runtime::init_ops_and_esm(), | |||
| ops::bootstrap::deno_bootstrap::init_ops_and_esm(), | |||
| ops::bootstrap::deno_bootstrap::init_ops_and_esm(None), | |||
There was a problem hiding this comment.
I don't like it, I wish we had an easy way to add a custom function just for snapshotting :(
Comment on lines
588
to
+594
| const { | ||
| 0: denoVersion, | ||
| 1: location_, | ||
| 2: tsVersion, | ||
| 3: unstableFlag, | ||
| 4: unstableFeatures, | ||
| 5: target, | ||
| 6: v8Version, | ||
| 8: enableTestingFeaturesFlag, | ||
| 9: hasNodeModulesDir, | ||
| 10: maybeBinaryNpmCommandName, | ||
| 0: location_, | ||
| 1: unstableFlag, | ||
| 2: unstableFeatures, | ||
| 4: enableTestingFeaturesFlag, | ||
| 5: hasNodeModulesDir, | ||
| 6: maybeBinaryNpmCommandName, |
bartlomieju
approved these changes
Nov 15, 2023
|
/bench startup_nop_trivial |
startup_nop_trivial
start: id: server: |
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21133