feat(unstable): tar up directory with deno.json #21228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
dsherret
reviewed
Nov 23, 2023
dsherret
reviewed
Nov 23, 2023
dsherret
reviewed
Nov 23, 2023
cli/tools/registry/mod.rs
Outdated
| packages: Vec<PreparedPublishPackage>, | ||
| auth_method: AuthMethod, | ||
| ) -> Result<(), AnyError> { | ||
| let client = reqwest::Client::new(); |
There was a problem hiding this comment.
Can we use the http client in the factory? It would be nice to get progress bars for everything it does.
There was a problem hiding this comment.
I had to make HttpClient::client method public to the crate to do that.
There was a problem hiding this comment.
In the future, we should make it private again and then improve the API of HttpClient to handle all these scenarios and show progress.
dsherret
reviewed
Nov 23, 2023
Comment on lines
+499
to
+504
| packages.push(prepare_publish(&initial_cwd, directory_path).await?); | ||
| } else { | ||
| println!("Publishing a workspace..."); | ||
| for member in members { | ||
| let member_dir = directory_path.join(member); | ||
| packages.push(prepare_publish(&initial_cwd, member_dir).await?); |
There was a problem hiding this comment.
I don't believe there's any need to provide the initial_cwd here?
crowlKats
pushed a commit
that referenced
this pull request
Nov 24, 2023
Co-authored-by: David Sherret <dsherret@gmail.com> Co-authored-by: Luca Casonato <lucacasonato@yahoo.com> Co-authored-by: Luca Casonato <hello@lcas.dev> (cherry picked from commit 585cf2d)
bartlomieju
added a commit
that referenced
this pull request
Nov 24, 2023
Co-authored-by: David Sherret <dsherret@gmail.com> Co-authored-by: Luca Casonato <lucacasonato@yahoo.com> Co-authored-by: Luca Casonato <hello@lcas.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.