Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dts): Deno.ChildProcess actually implements AsyncDisposable #21326

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Nov 24, 2023

async [SymbolAsyncDispose]() {
try {
ops.op_spawn_kill(this.#rid, "SIGTERM");
} catch {
// ignore errors from killing the process (such as ESRCH or BadResource)
}
await this.#status;
}

As seen above, what Deno.ChildProcess actually implements is AsyncDisposable, but the type declaration says it's Disposable. This PR fixes the type declaration to match the actual implementation.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna merged commit 00e4c47 into denoland:main Nov 25, 2023
14 checks passed
@magurotuna magurotuna deleted the fix-childprocess-async-dispose branch November 25, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants