Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): spawnSync's status was incorrect #21359

Merged
merged 3 commits into from Nov 28, 2023

Conversation

dsherret
Copy link
Member

The exit code wasn't hooked up properly.

Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch LGTM

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit d4ef471 into denoland:main Nov 28, 2023
14 checks passed
@dsherret dsherret deleted the fix_node_spawn_sync branch November 28, 2023 00:54
bartlomieju pushed a commit that referenced this pull request Nov 30, 2023
The exit code wasn't hooked up properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants