Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permissions): fix panics when revoking net permission #21388

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix(permissions): fix panics when revoking net permission #21388

merged 2 commits into from
Dec 1, 2023

Conversation

liruifengv
Copy link
Contributor

fix #21385

@liruifengv liruifengv changed the title fix panics when revoking net permission fix(permissions): fix panics when revoking net permission Nov 30, 2023
@crowlKats
Copy link
Member

Could we get a test?

@liruifengv
Copy link
Contributor Author

Could we get a test?

Done

crowlKats
crowlKats approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats merged commit fc8f060 into denoland:main Dec 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno panics when revoking net permission
2 participants
@liruifengv @crowlKats