perf(lsp): better op performance logging #21423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Dec 1, 2023
| state: &mut OpState, | ||
| #[serde] args: SpecifierArgs, | ||
| ) -> Result<Option<LoadResponse>, AnyError> { | ||
| ) -> Result<v8::Local<'s, v8::Value>, AnyError> { |
There was a problem hiding this comment.
We should return an array with 3 elements here, instead of using an object (lower pressure on GC and faster to serialize because no need to serialize 3 keys as strings)
bartlomieju
commented
Dec 1, 2023
| #[op2] | ||
| #[string] | ||
| fn op_script_version( | ||
| state: &mut OpState, | ||
| #[serde] args: ScriptVersionArgs, | ||
| #[string] specifier: &str, |
There was a problem hiding this comment.
Slight perf improvement - no need to use an object here if it's a single string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.