Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zlib): handle no flush flag in handle_.write #21432

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix(zlib): handle no flush flag in handle_.write #21432

merged 3 commits into from
Dec 13, 2023

Conversation

littledivy
Copy link
Member

Fixes #21096

@bartlomieju
Copy link
Member

Can you add a test that exercises this case?

@littledivy littledivy enabled auto-merge (squash) December 13, 2023 16:10
@mmastrac mmastrac enabled auto-merge (squash) December 13, 2023 16:58
@mmastrac mmastrac merged commit 38002ff into denoland:main Dec 13, 2023
14 checks passed
@littledivy littledivy deleted the zlib_fix_i32 branch December 13, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: expected i32
3 participants
@littledivy @bartlomieju @mmastrac