perf(lsp): check tsc request cancellation before execution #21447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Dec 3, 2023
Comment on lines
-1618
to
-1622
| #[tokio::test] | ||
| async fn test_cancelled_ts_diagnostics_request() { | ||
| let temp_dir = TempDir::new(); | ||
| let (snapshot, cache_location) = setup( | ||
| &temp_dir, |
There was a problem hiding this comment.
I don't understand why this test need to be removed...
There was a problem hiding this comment.
It no longer returns empty diagnostics but gives a cancelled error. Since it's not a meaningful or unique case anymore I just removed the test
Martin978
added a commit
to Martin978/deno
that referenced
this pull request
Dec 3, 2023
…enoland#21447)" This reverts commit 0a738dc.
nayeemrmn
deleted the
lsp-tsc-request-check-cancelled-before-execution
branch
bartlomieju
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of requests get cancelled before they get to the front of the queue. This should speed up those cases.