Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): do not create symlink for non-system optional dep in node_modules directory #21478

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(npm): do not create symlink for non-system optional dep in node_modules directory #21478

merged 1 commit into from
Dec 6, 2023
+34 −4

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 6, 2023

Closes #21476

bartlomieju
bartlomieju approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 9bdc9e4 into denoland:main Dec 6, 2023
14 checks passed
@dsherret dsherret deleted the fix_node_modules_symlink branch December 6, 2023 19:24
@cknight cknight mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run "deno compile" on Fresh project with Tailwind support (node_modules issue)
2 participants
@dsherret @bartlomieju