Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow reserved word 'mod' in exports #21537

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: allow reserved word 'mod' in exports #21537

merged 2 commits into from
Dec 11, 2023

Conversation

ry
Copy link
Member

@ry ry commented Dec 11, 2023 •
edited

This problem occurred trying to load tensorflow.js

> import * as tf from 'npm:@tensorflow/tfjs';
Uncaught SyntaxError: Identifier 'mod' has already been declared at file:///Users/ry/Library/Caches/deno/npm/registry.npmjs.org/@tensorflow/tfjs/4.14.0/dist/tf.node.js:167:14
    at async <anonymous>:1:33

@ry ry requested a review from dsherret December 11, 2023 14:40
dsherret
dsherret approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 98121de into main Dec 11, 2023
14 checks passed
@ry ry deleted the mod-reserved-words branch December 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @dsherret