feat: Implement QUIC #21942

devsnek · 2024-01-15T04:23:47Z

Implements a QUIC interface, loosely based on the WebTransport API (a future change could add the WebTransport API, built on top of this one).

quinn is used for the underlying QUIC implementation, for a few reasons:

A cloneable "handle" api which fits quite nicely into deno resources.
Good collaboration with the rust ecosystem, especially rustls.
I like it.

littledivy

nice API 👍

Cargo.lock

cli/tests/unit/quic_test.ts

mmastrac

This looks pretty good. I agree with @littledivy's comments re: ring.

I think we should consider merging this into ext/net rather than creating a new module, however.

ext/quic/01_quic.js

ext/quic/lib.deno_quic.d.ts

bartlomieju

@devsnek this is fantastic work, I'm impressed how few lines of code you needed to implement that 💪

ext/quic/01_quic.js

ext/quic/lib.rs

bartlomieju · 2024-02-05T23:18:15Z

@devsnek we'll get more reviews in this week and aim to land it for v1.41.

ext/quic/01_quic.js

hironichu · 2024-02-19T12:31:16Z

How hard or how long would it take to implement Webtransport with this PR ?

My suggestion is : why not adding it at the same time before merging in 1.41 since WT is 76% available on the browsers.

Adding a client seems "easy" enough, and a server which is upgrading the QUIC transport connection to a server (somewhat like Websocket works at the moment)

lino-levan · 2024-04-05T15:56:38Z

How hard or how long would it take to implement WebTransport with this PR ?

Probably should be done in a separate PR imo. I'm really excited about this! Is there any consideration for this in deno 1.43 @bartlomieju?

iuioiua

Very nicely done. Most of my suggestions are little nits. However, same as @mmastrac, I question whether this should be done as an extra module rather than within ext/net.

Either way, can you please resolve the merge conflicts?

ext/quic/lib.deno_quic.d.ts

ext/quic/01_quic.js

iuioiua · 2024-04-06T00:10:38Z

runtime/js/90_deno_ns.js

+  connectQuic: quic.connectQuic,
+  listenQuic: quic.listenQuic,
+  QuicBidirectionalStream: quic.QuicBidirectionalStream,
+  QuicConn: quic.QuicConn,
+  QuicListener: quic.QuicListener,
+  QuicReceiveStream: quic.QuicReceiveStream,
+  QuicSendStream: quic.QuicSendStream,
 };



We can either include these classes in the Deno.* namespace or make the constructors of these classes illegal. The former adds to the API surface area, but the latter enables such objects to be identified with the use of instanceof. Which should we do? @bartlomieju

hironichu · 2024-04-17T20:06:48Z

Very nicely done. Most of my suggestions are little nits. However, same as @mmastrac, I question whether this should be done as an extra module rather than within ext/net.

Either way, can you please resolve the merge conflicts?

I also think we should merge it into ext/net, and if we want to make protocol that depends on QUIC then we can make module ( i.e WebTransport and Media over Quic (MoQ)..

iuioiua

Mostly documentation nits.

iuioiua · 2024-07-10T05:11:26Z

ext/net/lib.deno_net.d.ts

+    maxIdleTimeout?: number;
+    /** Maximum number of incoming bidirectional streams that may be open
+     * concurrently.
+     * Default: 100


Suggested change

* Default: 100

* @default {100}

iuioiua · 2024-07-10T05:11:47Z

ext/net/lib.deno_net.d.ts

+    maxConcurrentBidirectionalStreams?: number;
+    /** Maximum number of incoming unidirectional streams that may be open
+     * concurrently.
+     * Default: 100


Suggested change

* Default: 100

* @default {100}

iuioiua · 2024-07-10T05:15:35Z

ext/net/lib.deno_net.d.ts

+  export interface ListenQuicOptions extends QuicTransportOptions {
+    /** The port to connect to. */
+    port: number;
+    /** A literal IP address or host name that can be resolved to an IP address. */


Suggested change

/** A literal IP address or host name that can be resolved to an IP address. */

/** A literal IP address or host name that can be resolved to an IP address.

*

* @default {"0.0.0.0"}

*/

Should we also add the same note that Deno.ServeOptions.hostname has?

iuioiua · 2024-07-10T05:17:24Z

ext/net/lib.deno_net.d.ts

+    accept(): Promise<QuicConn>;
+    refuse(): Promise<void>;
+    ignore(): Promise<void>;


Should these have descriptions?

iuioiua · 2024-07-10T05:18:03Z

ext/net/lib.deno_net.d.ts

+     * which the value has been set. */
+    sendOrder?: number;
+    /** Wait until there is sufficient flow credit to create the stream.
+     * Defaults to false.


Suggested change

* Defaults to false.

* @default {false}

iuioiua · 2024-07-10T05:19:52Z

ext/net/lib.deno_net.d.ts

+  export interface QuicSendStreamOptions {
+    /** Indicates the send priority of this stream relative to other streams for
+     * which the value has been set. */
+    sendOrder?: number;


What's the default behavior of this property?

devsnek force-pushed the quic branch 2 times, most recently from 8d2f39b to 84747e1 Compare January 15, 2024 04:29

littledivy reviewed Jan 15, 2024

View reviewed changes

Cargo.lock Outdated Show resolved Hide resolved

cli/tests/unit/quic_test.ts Outdated Show resolved Hide resolved

devsnek force-pushed the quic branch 4 times, most recently from 28254df to f7eb83e Compare January 15, 2024 06:47

devsnek changed the title ~~[wip] quic~~ Implement QUIC Jan 15, 2024

devsnek marked this pull request as ready for review January 15, 2024 06:53

devsnek force-pushed the quic branch 4 times, most recently from 37df306 to aec0bb8 Compare January 15, 2024 07:23

devsnek mentioned this pull request Jan 15, 2024

QUIC & HTTP/3 support #1558

Open

devsnek force-pushed the quic branch 4 times, most recently from e208a10 to 6d9a15f Compare January 15, 2024 19:32

mmastrac reviewed Jan 15, 2024

View reviewed changes

ext/quic/01_quic.js Outdated Show resolved Hide resolved

mmastrac reviewed Jan 15, 2024

View reviewed changes

ext/quic/lib.deno_quic.d.ts Outdated Show resolved Hide resolved

devsnek changed the title ~~Implement QUIC~~ feat: Implement QUIC Jan 15, 2024

devsnek force-pushed the quic branch 3 times, most recently from d05ef59 to 823a8f9 Compare January 15, 2024 22:48

bartlomieju reviewed Jan 15, 2024

View reviewed changes

ext/quic/01_quic.js Outdated Show resolved Hide resolved

ext/quic/01_quic.js Outdated Show resolved Hide resolved

ext/quic/lib.rs Outdated Show resolved Hide resolved

devsnek force-pushed the quic branch 4 times, most recently from a5b1091 to 7645454 Compare January 18, 2024 06:09

devsnek force-pushed the quic branch from 7645454 to 2dc8326 Compare January 18, 2024 07:17

devsnek force-pushed the quic branch from 2dc8326 to 0784fdd Compare February 3, 2024 05:50

petamoriken reviewed Feb 12, 2024

View reviewed changes

ext/quic/01_quic.js Outdated Show resolved Hide resolved

devsnek force-pushed the quic branch 2 times, most recently from b7fdfb6 to 001fb6a Compare February 13, 2024 18:32

mmastrac added this to the 1.41 milestone Feb 13, 2024

devsnek force-pushed the quic branch 2 times, most recently from 4d4f24e to b21790d Compare February 19, 2024 05:08

devsnek force-pushed the quic branch 3 times, most recently from 8638073 to c8e070f Compare February 25, 2024 18:32

bartlomieju removed this from the 1.41 milestone Mar 6, 2024

iuioiua requested changes Apr 6, 2024

View reviewed changes

devsnek force-pushed the quic branch 2 times, most recently from 4fe503b to e2156ca Compare July 10, 2024 01:37

iuioiua requested changes Jul 10, 2024

View reviewed changes

feat: Implement QUIC

89add38

devsnek force-pushed the quic branch from e2156ca to 89add38 Compare July 12, 2024 22:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement QUIC #21942

feat: Implement QUIC #21942

devsnek commented Jan 15, 2024

littledivy left a comment

mmastrac left a comment

bartlomieju left a comment

bartlomieju commented Feb 5, 2024

hironichu commented Feb 19, 2024 •

edited

Loading

lino-levan commented Apr 5, 2024

iuioiua left a comment

iuioiua Apr 6, 2024

hironichu commented Apr 17, 2024

iuioiua left a comment

iuioiua Jul 10, 2024

iuioiua Jul 10, 2024

iuioiua Jul 10, 2024

iuioiua Jul 10, 2024

iuioiua Jul 10, 2024

iuioiua Jul 10, 2024

feat: Implement QUIC #21942

Are you sure you want to change the base?

feat: Implement QUIC #21942

Conversation

devsnek commented Jan 15, 2024

littledivy left a comment

Choose a reason for hiding this comment

mmastrac left a comment

Choose a reason for hiding this comment

bartlomieju left a comment

Choose a reason for hiding this comment

bartlomieju commented Feb 5, 2024

hironichu commented Feb 19, 2024 • edited Loading

lino-levan commented Apr 5, 2024

iuioiua left a comment

Choose a reason for hiding this comment

iuioiua Apr 6, 2024

Choose a reason for hiding this comment

hironichu commented Apr 17, 2024

iuioiua left a comment

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

iuioiua Jul 10, 2024

Choose a reason for hiding this comment

hironichu commented Feb 19, 2024 •

edited

Loading