Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unstable): implement navigator.gpu.getPreferredCanvasFormat() #22149

Merged
merged 1 commit into from Jan 27, 2024

Conversation

littledivy
Copy link
Member

No description provided.

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not ideal, but should be fine for majority of cases, so LGTM

@littledivy
Copy link
Member Author

It's the same implementation from Firefox and Chrome so I think it's fine.

@crowlKats
Copy link
Member

It's the same implementation from Firefox and Chrome so I think it's fine.

yes but they have completely different usecase than us, given that in our scneario this will be used as a surface texture format, whereas in browsers is just used on part of a wider system.

@littledivy littledivy changed the title feat(gpu): implement navigator.gpu.getPreferredCanvasFormat() feat(unstable): implement navigator.gpu.getPreferredCanvasFormat() Jan 27, 2024
@littledivy littledivy merged commit cc0a372 into denoland:main Jan 27, 2024
14 checks passed
@littledivy littledivy deleted the preferred_canvas_format branch January 27, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants