Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix segmentation fault in tests on CPUs with PKU support #22152

Merged
merged 4 commits into from Feb 5, 2024
Merged

fix: Fix segmentation fault in tests on CPUs with PKU support #22152

merged 4 commits into from Feb 5, 2024

Conversation

Digifox03
Copy link
Contributor

This is a followup on denoland/deno_core#471.

Fixes #21439.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as it will only be used when building test targets. @mmastrac does it look okay for you?

@lucacasonato
Copy link
Member

@bartlomieju features apply to all targets, regardless of if they are defined in dev-dependencies or dependencies

@mmastrac
Copy link
Member

mmastrac commented Feb 5, 2024

I believe that as long as we specify resolver = 2 and/or edition = 2021, features from dev-dependencies are split from those in dependencies. See rust-lang/cargo#10719 for more info.

cargo tree appears to lie about the features enabled for CLI, however. I manually ran this branch and can see that we compile the new_default_platform branch when running CLI.

I wonder if this is actually an upstream Rust bug that only affects the feature display.

@mmastrac mmastrac merged commit cb407bb into denoland:main Feb 5, 2024
15 checks passed
mmastrac pushed a commit to mmastrac/deno that referenced this pull request Feb 5, 2024
@Digifox03 @mmastrac
fix: Fix segmentation fault in tests on CPUs with PKU support (denola…
493b3b6 
…nd#22152)

This is a followup on denoland/deno_core#471.

Fixes denoland#21439.
littledivy pushed a commit that referenced this pull request Feb 8, 2024
@Digifox03 @littledivy
fix: Fix segmentation fault in tests on CPUs with PKU support (#22152)
966d9b0 
This is a followup on denoland/deno_core#471.

Fixes #21439.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault when running cargo test
5 participants
@Digifox03 @CLAassistant @lucacasonato @mmastrac @bartlomieju