fix(lsp): don't normalize urls in cache command params #22182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Jan 30, 2024
| self.task_queue.queue_task(Box::new(|ls: LanguageServer| { | ||
| spawn(async move { | ||
| if let Err(err) = | ||
| ls.cache_request(Some(json!(cache_params))).await | ||
| ls.cache_request(specifiers, referrer).await |
There was a problem hiding this comment.
+1... kind of crazy we were doing that 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22122. We shouldn't do this normalization because the params to the cache command come from the server's quick-fixes and are never denormalized to client URLs in the first place. It was causing a faulty memoization in the URL mapper.
BTW the fix is a one line change removing the
normalize_url()call from https://github.com/denoland/deno/blob/v1.40.2/cli/lsp/language_server.rs#L3723. But I cleaned up the param types across the cache command helpers to make it clear that these are actual module specifiers, not client URLs. Also removed some old custom requests that were moved to commands.