Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): fix timeout param validation in cp.execFile #22262

Merged
merged 1 commit into from Feb 5, 2024
Merged

fix(ext/node): fix timeout param validation in cp.execFile #22262

merged 1 commit into from Feb 5, 2024
+18 −9

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 5, 2024

fixes #22261

@kt3k kt3k requested a review from mmastrac February 5, 2024 03:39
littledivy
littledivy approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 961fa27 into denoland:main Feb 5, 2024
15 checks passed
@kt3k kt3k deleted the fix-exec-file-timeout branch February 5, 2024 05:28
littledivy pushed a commit that referenced this pull request Feb 8, 2024
@kt3k @littledivy
fix(ext/node): fix timeout param validation in cp.execFile (#22262)
fc14e19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@mmastrac mmastrac Awaiting requested review from mmastrac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:child_process::execFile does not support timeout: undefined
2 participants
@kt3k @littledivy