Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: add Deno.CreateHttpClientOptions.{cert,key} #22280

Merged
merged 1 commit into from Feb 18, 2024
Merged

BREAKING: add Deno.CreateHttpClientOptions.{cert,key} #22280

merged 1 commit into from Feb 18, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Feb 6, 2024 •
edited

This change deprecates Deno.CreateHttpClientOptions.{certChain,privateKey} in favour of Deno.CreateHttpClientOptions.{cert,key}.

Closes #22278

@mmastrac
Copy link
Member

mmastrac commented Feb 13, 2024 •
edited

Let's add warnOnDeprecatedApi to the older fields.

Nevermind -- this is an unstable API.

@mmastrac mmastrac added this to the 1.41 milestone Feb 13, 2024
mmastrac
mmastrac approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending merge fix.

@iuioiua iuioiua marked this pull request as draft February 13, 2024 22:22
@iuioiua iuioiua marked this pull request as ready for review February 13, 2024 22:34
@iuioiua iuioiua marked this pull request as draft February 13, 2024 22:40
@mmastrac mmastrac force-pushed the createhttpclientoptions-cert-key branch from a63fe88 to 36515d8 Compare February 13, 2024 22:49
@mmastrac mmastrac force-pushed the createhttpclientoptions-cert-key branch from 36515d8 to 5377841 Compare February 13, 2024 22:51
@iuioiua iuioiua marked this pull request as ready for review February 13, 2024 22:53
@mmastrac mmastrac merged commit 3a243c8 into denoland:main Feb 18, 2024
20 checks passed
@iuioiua iuioiua deleted the createhttpclientoptions-cert-key branch February 18, 2024 21:07
@iuioiua iuioiua mentioned this pull request Feb 22, 2024
Merged
mmastrac pushed a commit that referenced this pull request Feb 23, 2024
@iuioiua
chore(cli): swap CreateHttpClientOptions.{cert,key} descriptions (#…
55fa61a 
…22543)

Fixes #22280 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhoabreu dinhoabreu dinhoabreu left review comments

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.

suggestion: rename Deno.CreateHttpClientOptions.{certChain,privateKey}
3 participants
@iuioiua @mmastrac @dinhoabreu