Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): Ensure os.cpus() works on arm64 linux #22302

Merged
merged 1 commit into from Feb 6, 2024

Conversation

mmastrac
Copy link
Member

@mmastrac mmastrac commented Feb 6, 2024

/proc/cpuinfo on ARM doesn't have the model name per CPU, so we leave those as "unknown".

@mmastrac mmastrac force-pushed the arm64_fix branch 3 times, most recently from b780296 to f9cbe2c Compare February 6, 2024 20:49
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmastrac mmastrac merged commit 33d12c1 into denoland:main Feb 6, 2024
15 checks passed
littledivy pushed a commit that referenced this pull request Feb 8, 2024
`/proc/cpuinfo` on ARM doesn't have the model name per CPU, so we leave
those as "unknown".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants