Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): add npm: suggestion for esm.sh specifiers #22343

Merged
merged 6 commits into from Mar 4, 2024

Conversation

littledivy
Copy link
Member

image

Not exactly sure how to use DiagnosticSnippet to replace the original source.

@ry ry requested a review from lucacasonato February 8, 2024 12:31
@dsherret
Copy link
Member

dsherret commented Feb 9, 2024

I'll rebase this PR for you because I have the context.

Signed-off-by: David Sherret <dsherret@users.noreply.github.com>
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a way we could add a test?

Copy link

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@littledivy littledivy merged commit 11db68c into denoland:main Mar 4, 2024
17 checks passed
@littledivy littledivy deleted the jsr_esm_sh_hint branch March 4, 2024 04:25
littledivy added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants