Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): export process.umask #22348

Merged
merged 1 commit into from Feb 13, 2024
Merged

fix(ext/node): export process.umask #22348

merged 1 commit into from Feb 13, 2024

Conversation

littledivy
Copy link
Member

Fixes #20914

kt3k
kt3k approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member

kt3k commented Feb 9, 2024

Note: Deno.umask() is racy

ref. #13632

@littledivy littledivy merged commit 492a9fb into denoland:main Feb 13, 2024
17 checks passed
@littledivy littledivy deleted the process_umask branch February 13, 2024 14:16
littledivy added a commit that referenced this pull request Feb 15, 2024
@littledivy
fix(ext/node): export process.umask (#22348)
4a7213e 
Fixes #20914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: Uncaught SyntaxError: The requested module 'node:process' does not provide an export named 'umask'
2 participants
@littledivy @kt3k