Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle non-file scopes in synthetic import map #22361

Merged
merged 1 commit into from Feb 9, 2024
Merged

fix: handle non-file scopes in synthetic import map #22361

merged 1 commit into from Feb 9, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 9, 2024

Closes #22353

mmastrac
mmastrac approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) February 9, 2024 02:04
@dsherret dsherret merged commit b011913 into denoland:main Feb 9, 2024
17 checks passed
@dsherret dsherret deleted the fix_import_map_scopes_remote branch February 9, 2024 06:32
littledivy pushed a commit that referenced this pull request Feb 15, 2024
@dsherret @littledivy
fix: handle non-file scopes in synthetic import map (#22361)
7ef1720 
Closes #22353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno panic on deno check when import map has https scopes
2 participants
@dsherret @mmastrac