fix: cache bust jsr deps on constraint failure #22372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 10, 2024
| @@ -1,4 +1,5 @@ | |||
| Download http://127.0.0.1:4250/@denotest/deps/meta.json | |||
| Download http://127.0.0.1:4250/@denotest/deps/meta.json | |||
| error: Could not find constraint in the list of versions: @denotest/deps@0.1.4 | |||
| Specifier: jsr:@denotest/deps@0.1.4/mod.ts | |||
| at file:///[WILDCARD]/version_not_found/main.ts:1:19 | |||
There was a problem hiding this comment.
A very minor issue is now we request the metadata twice even if the metadata was not originally loaded from the cache. Fixing this would require telling deno_graph about if a specifier was loaded from the cache or not, which I think would be too much complexity and isn't worth fixing.
littledivy
pushed a commit
that referenced
this pull request
Feb 15, 2024
Removes the `FileFetcher`'s internal cache because I don't believe it's necessary (we already cache this kind of stuff in places like deno_graph or config files in different places). Removing it fixes this bug because this functionality was already implemented in deno_graph and lowers memory usage of the CLI a little bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
FileFetcher's internal cache because I don't believe it's necessary (we already cache this kind of stuff in places like deno_graph or config files in different places). Removing it fixes this bug because this functionality was already implemented in deno_graph and lowers memory usage of the CLI a little bit.