Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): jsr support with cache probing #22418

Merged
merged 5 commits into from Feb 14, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Follow up to #22382. This bring JSR support up to par with https and npm specifiers.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Maybe we should add a test for when a version is not in the cache, then we cache it?

tests/integration/lsp_tests.rs Show resolved Hide resolved
cli/lsp/jsr_resolver.rs Outdated Show resolved Hide resolved
cli/lsp/jsr_resolver.rs Outdated Show resolved Hide resolved
cli/lsp/jsr_resolver.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit 1ad754b into denoland:main Feb 14, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jsr-no-lockfile branch February 14, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants