feat(unstable/lint): no-slow-types for JSR packages #22430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| if !any_pkg_had_diagnostics { | ||
| // this is a temporary measure until we know that fast check is reliable and stable | ||
| let check_diagnostics = type_checker |
There was a problem hiding this comment.
We should probably also run a type check before publish (without fast check) - let's do that in a follow up. And the if the user passes --no-check we should maybe also ignore the fast check verification type check
|
Good feedback. Thanks! I opened #22437 |
lucacasonato
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-slow-typeslint rule.deno lintfor packages (deno.json files with a name, version, and exports field)--no-slow-types