fix(ext/node): add alternative RSA OID #22511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Feb 21, 2024
Comment on lines
1396
to
1398
| let private_key = | ||
| rsa::pkcs1::RsaPrivateKey::from_der(pk_info.private_key)?; | ||
| let modulus_length = private_key.modulus.as_bytes().len() * 8; |
There was a problem hiding this comment.
Currently encountering error:
Error: unexpected ASN.1 DER tag: expected SEQUENCE, got INTEGER
littledivy
reviewed
Mar 13, 2024
There was a problem hiding this comment.
The OID has .3.1 ending hence so I'm pretty sure that's not related to RSA
http://oid-info.com/get/1.2.840.113549.1.3.1
This is the object identifier for dhKeyAgreement defined in PKCS #3: Diffie-Hellman KeyAgreement Standard (1993). PDF
The key material in the PEM is DH private key.
littledivy
added a commit
that referenced
this pull request
Mar 14, 2024
|
This has been superseded by #22891. |
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #22489, I noticed that this private key was unable to be created using
crypto.createPrivateKey(). This is because it uses an RSA OID,1.2.840.113549.1.3.1, which is less commonly used than the currently used one,1.2.840.113549.1.1.1. This change adds the lesser-used RSA OID.CC @littledivy