New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable): deno add
subcommand
#22520
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
be4e4bc
wip
bartlomieju c32b358
something is working
bartlomieju 00a3699
Merge branch 'main' into deno_add
bartlomieju c8aa094
more resilient
bartlomieju 5879ffb
remove deno.json
bartlomieju 60b742e
Merge branch 'main' into deno_add
bartlomieju c7f18e0
cleanup
bartlomieju 29d1a16
Merge branch 'main' into deno_add
bartlomieju 0e7825d
make retrieval concurrent
bartlomieju 657ce8c
improve the cli
bartlomieju 9ea21a9
Merge branch 'main' into deno_add
bartlomieju bc31f4b
need to do semver resolution still and handle npm
bartlomieju aff61a3
handle npm
bartlomieju 4f1d987
start writing tests
bartlomieju d51a6dc
add tests
bartlomieju 0cadde8
lint
bartlomieju ba1a163
fix validation
bartlomieju 231bfbe
adjust test so we can cache it
bartlomieju 3b64bd2
add a todo
bartlomieju 4e71e9d
update example in flags.rs
bartlomieju ba55df4
use assert_matches_json
bartlomieju c81e785
move add to the top of the file
bartlomieju 9642410
use log::info instead of eprintln
bartlomieju 6809f9d
lint, rename version to version_req
bartlomieju 2840239
wip
bartlomieju 602f743
Merge branch 'main' into deno_add
bartlomieju 4f66610
wip
bartlomieju d79f757
use PackageSearchApi
bartlomieju f2788a9
revert test server change
bartlomieju ec49ef6
decode %2F as well
bartlomieju 5e436aa
lint
bartlomieju a9ac65e
Merge branch 'main' into deno_add
bartlomieju 7bee45e
revert unrelated changes
bartlomieju 69b0082
Merge branch 'main' into deno_add
bartlomieju File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future we should move these out of the lsp module to somewhere more common since we're going to be using this for more than the lsp now (cc @nayeemrmn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're just using
CliJsrSearchApi::versions()
injsr_find_package_and_select_version
. I think we ought to be usingJsrResolver::req_to_nv()
there or something.. we can modify it to be usable with both fetch or cached-only logic. I'll look into it in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nayeemrmn sounds like a good idea. Could you also improve
deno add
to handlenpm:
specifiers? For now I left it erroring (there are tests that verify it).