Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): respect compiler options for emit #22521

Merged
merged 4 commits into from
Feb 21, 2024
Merged

fix(compile): respect compiler options for emit #22521

merged 4 commits into from
Feb 21, 2024

Conversation

bartlomieju
Copy link
Member

deno compile was ignoring configuration file and thus not applying
compilerOptions to influence the way files were emitted.

dsherret
dsherret approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju enabled auto-merge (squash) February 21, 2024 22:49
@bartlomieju bartlomieju merged commit 197d248 into denoland:main Feb 21, 2024
17 checks passed
@bartlomieju bartlomieju deleted the deno_compile_respect_compiler_options branch February 21, 2024 23:04
@cleverplatypus cleverplatypus mentioned this pull request Mar 9, 2024
Open
@sgvictorino sgvictorino mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @dsherret