Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(fmt): reduce memory usage and improve performance #22570

Merged
merged 2 commits into from Feb 23, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 23, 2024

Reduces memory usage of the fmt command and fixes a memory leak.

Also slightly improves performance.

Before:

deno_std % hyperfine --prepare 'rm /Users/david/Library/Caches/deno/fmt_incremental_cache_v1' --warmup 5 '../deno/target/release/deno fmt'    
Benchmark 1: ../deno/target/release/deno fmt
  Time (mean ± σ):     155.4 ms ±  30.5 ms    [User: 1093.3 ms, System: 119.7 ms]
  Range (min … max):   132.8 ms … 248.8 ms    21 runs

After:

deno_std % hyperfine --prepare 'rm /Users/david/Library/Caches/deno/fmt_incremental_cache_v1' --warmup 5 '../deno/target/release/deno_new fmt'
Benchmark 1: ../deno/target/release/deno_new fmt
  Time (mean ± σ):     139.6 ms ±  12.2 ms    [User: 1099.0 ms, System: 112.1 ms]
  Range (min … max):   131.0 ms … 188.1 ms    20 runs

@dsherret dsherret changed the title perf(fmt): reduce memory usage perf(fmt): reduce memory usage and improve performance Feb 23, 2024
@dsherret dsherret merged commit 22cd8eb into denoland:main Feb 23, 2024
17 checks passed
@dsherret dsherret deleted the perf_fmt_reduce_memory_usage branch February 23, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants