feat(publish): provenance attestation #22573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
littledivy
commented
Feb 24, 2024
littledivy
commented
Feb 24, 2024
littledivy
commented
Feb 24, 2024
littledivy
commented
Feb 25, 2024
Comment on lines
+950
to
+970
| for (path, entry) in manifest.manifest { | ||
| // Verify each path with the files in the tarball. | ||
| let file = package | ||
| .tarball | ||
| .files | ||
| .iter() | ||
| .find(|f| f.path_str == path.as_str()); | ||
|
|
||
| if let Some(file) = file { | ||
| if file.hash != entry.checksum { | ||
| bail!( | ||
| "Checksum mismatch for {}: expected {}, got {}", | ||
| path, | ||
| entry.checksum, | ||
| file.hash | ||
| ); | ||
| } | ||
| } else { | ||
| bail!("File {} not found in the tarball", path); | ||
| } | ||
| } |
There was a problem hiding this comment.
This doesn't check yet whether the registry removed a file (sorry to be picky)
lucacasonato
approved these changes
Feb 27, 2024
Comment on lines
+2399
to
+2404
| .arg( | ||
| Arg::new("provenance") | ||
| .long("provenance") | ||
| .help("From CI/CD system, publicly links the package to where it was built and published from.") | ||
| .action(ArgAction::SetTrue) | ||
| ) |
There was a problem hiding this comment.
We can also do this in a follow up, but can we enable provenance by default when we are using GH OIDC for auth?
And then add a --no-provenance option to force it off, and --provenance option to force it on.
We can then also use --provenance to do enable provenance for local publishes at some later date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply chain security for JSR.