Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(io): create_named_pipe parallelism #22597

Merged
merged 16 commits into from Feb 27, 2024
Merged

Conversation

mmastrac
Copy link
Member

@mmastrac mmastrac commented Feb 26, 2024

Investigating #22574

Unable to reproduce with a unit test, but assuming that it's a name collision or create pipe/open pipe race, and adding some additional diagnostics.

@mmastrac mmastrac changed the title fix(io): create_named_pipe parallelism fix(io): create_named_pipe parallelism [WIP] Feb 26, 2024
@mmastrac mmastrac changed the title fix(io): create_named_pipe parallelism [WIP] fix(io): create_named_pipe parallelism Feb 26, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmastrac mmastrac merged commit d722de8 into denoland:main Feb 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants