fix(cli): ensure that pre- and post-test output is flushed at the appropriate times #22611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
mmastrac
force-pushed
the
channel_test
branch
from
442446e
to
20de3f4
Compare
mmastrac
commented
Feb 28, 2024
| #[tokio::test] | ||
| async fn websocket_server_idletimeout() { | ||
| test_util::timeout!(60); |
There was a problem hiding this comment.
This test was using deno test to bypass a hang, but that stopped working with this change. I (mostly) fixed the test by just forcing an exit.
bartlomieju
reviewed
Feb 28, 2024
tests/testdata/test/load_unload.out
Outdated
Comment on lines
9
to
13
| ----- output end ----- | ||
| test ... ok ([WILDCARD]) | ||
| ------- post-test output ------- | ||
| unload | ||
| ----- output end ----- |
There was a problem hiding this comment.
This is a bit confusing - we have output end two end. Is this actually expected?
There was a problem hiding this comment.
The output end matches with post-test output.
Maybe I can clarify this by making the pairs ------- post-test output ------- and ------- post-test output end ------- instead. WDYT?
There was a problem hiding this comment.
I think it will be less confusing, so +1 from me
mmastrac
force-pushed
the
channel_test
branch
from
63c3dfc
to
c60c4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
deno_stdtests were failing to print output that was resolved after the last test finished. In addition, output printed before tests began would sometimes appear above the "running X tests ..." line, and sometimes below it depending on timing.We now guarantee that all output is flushed before and after tests run, making the output consistent.
Pre-test and post-test output are captured in
------ pre-test output ------and------ post-test output ------blocks to differentiate them from the regular output blocks.Here's an example of a test (that is much noisier than normal, but an example of what the output will look like):