Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node) add node http methods #22630

Merged
merged 11 commits into from Feb 29, 2024
Merged

fix(ext/node) add node http methods #22630

merged 11 commits into from Feb 29, 2024

Conversation

igorzi
Copy link
Contributor

@igorzi igorzi commented Feb 29, 2024

fixes #22627

This PR fixes a node compat issue that is preventing serverless-http and serverless-express npm modules from working with Deno. These modules are useful for running apps on AWS Lambda (and other serverless infra).

Signed-off-by: Igor Zinkovsky <igor@deno.com>
@igorzi igorzi changed the title fix(ext/node) make IncomingMessage props settable fix(ext/node) add node http methods Feb 29, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice tests

@dsherret dsherret merged commit dc16c99 into main Feb 29, 2024
17 checks passed
@dsherret dsherret deleted the fix_serverless branch February 29, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno doesn't work with serverless-http and serverless-express
3 participants