Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): force flush output after test unloads #22660

Merged
merged 1 commit into from Mar 1, 2024
Merged

fix(cli): force flush output after test unloads #22660

merged 1 commit into from Mar 1, 2024

Conversation

mmastrac
Copy link
Member

@mmastrac mmastrac commented Mar 1, 2024 •
edited

Fixes flake in load_unload test

dsherret
dsherret approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmastrac mmastrac enabled auto-merge (squash) March 1, 2024 20:48
@mmastrac mmastrac merged commit 2e4a1fc into denoland:main Mar 1, 2024
17 checks passed
littledivy pushed a commit that referenced this pull request Mar 8, 2024
@mmastrac @littledivy
fix(cli): force flush output after test unloads (#22660)
95cbc0b 
Fixes flake in load_unload test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmastrac @dsherret