fix(cli): remove possible deadlock in test channel #22662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
commented
Mar 1, 2024
| let Some(stream) = &mut self.read_opt else { | ||
| return; |
There was a problem hiding this comment.
This could lead to starvation as we just quietly returned "ready" and tokio could select us again.
mmastrac
commented
Mar 1, 2024
cli/tools/test/channel.rs
Outdated
| @@ -253,7 +265,7 @@ impl TestEventSenderFactory { | |||
| loop { | |||
| tokio::select! { | |||
| _ = test_stdout.pipe(), if test_stdout.is_alive() => {}, | |||
| _ = test_stderr.pipe(), if test_stdout.is_alive() => {}, | |||
| _ = test_stderr.pipe(), if test_stderr.is_alive() => {}, | |||
There was a problem hiding this comment.
This typo here meant that we were polling test_stderr in a hot loop if it finished, never getting to the sync receiver
mmastrac
commented
Mar 1, 2024
| @@ -377,7 +389,9 @@ impl TestEventSender { | |||
| let mutex = parking_lot::RawMutex::INIT; | |||
| mutex.lock(); | |||
| self.sync_sender.send(SendMutex(&mutex as _))?; | |||
| mutex.lock(); | |||
| if !mutex.try_lock_for(Duration::from_secs(30)) { | |||
bartlomieju
approved these changes
Mar 5, 2024
littledivy
pushed a commit
that referenced
this pull request
Mar 8, 2024
The stderr stream could possibly starve the other bits of the output-redirecting event loop. Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stderr stream could possibly starve the other bits of the output-redirecting event loop.