Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): include registry url in jsr import hover text #22676

Merged
merged 1 commit into from Mar 4, 2024
Merged

feat(lsp): include registry url in jsr import hover text #22676

merged 1 commit into from Mar 4, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn requested a review from dsherret March 3, 2024 08:19
dsherret
dsherret approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! LGTM!

@nayeemrmn nayeemrmn merged commit 625a931 into denoland:main Mar 4, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jsr-hover branch March 5, 2024 03:01
littledivy pushed a commit that referenced this pull request Mar 8, 2024
@nayeemrmn @littledivy
feat(lsp): include registry url in jsr import hover text (#22676)
6aee866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to navigate to the source of a package via jsr:@.
2 participants
@nayeemrmn @dsherret