fix(ext/node): http2.createServer

ext/node/polyfills/internal/errors.ts

@@ -2248,6 +2248,16 @@ export class ERR_FALSY_VALUE_REJECTION extends NodeError {
     this.reason = reason;
   }
 }
+
+export class ERR_HTTP2_TOO_MANY_CUSTOM_SETTINGS extends NodeError {
+  constructor() {
+    super(
+      "ERR_HTTP2_TOO_MANY_CUSTOM_SETTINGS",
+      "Number of custom settings exceeds MAX_ADDITIONAL_SETTINGS",
+    );
+  }
+}
+
 export class ERR_HTTP2_INVALID_SETTING_VALUE extends NodeRangeError {
   actual: unknown;
   min?: number;

tests/unit/chmod_test.ts

@@ -4,7 +4,7 @@ import {
   assertEquals,
   assertRejects,
   assertThrows,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test(
   {

tests/unit/command_test.ts

@@ -6,7 +6,7 @@ import {
   assertRejects,
   assertStringIncludes,
   assertThrows,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test(
   { permissions: { write: true, run: true, read: true } },

tests/unit/files_test.ts

@@ -7,7 +7,7 @@ import {
   assertEquals,
   assertRejects,
   assertThrows,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 import { copy } from "@std/streams/copy.ts";
 
 // Note tests for Deno.FsFile.setRaw is in integration tests.

tests/unit/read_file_test.ts

@@ -6,7 +6,7 @@ import {
   assertThrows,
   pathToAbsoluteFileUrl,
   unreachable,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test({ permissions: { read: true } }, function readFileSyncSuccess() {
   const data = Deno.readFileSync("tests/testdata/assets/fixture.json");

tests/unit/real_path_test.ts

@@ -6,7 +6,7 @@ import {
   assertRejects,
   assertThrows,
   pathToAbsoluteFileUrl,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test({ permissions: { read: true } }, function realPathSyncSuccess() {
   const relative = "tests/testdata/assets/fixture.json";

tests/unit/serve_test.ts

@@ -8,10 +8,12 @@ import {
   assertEquals,
   assertStringIncludes,
   assertThrows,
+  curlRequest,
+  curlRequestWithStdErr,
   execCode,
   fail,
   tmpUnixSocketPath,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 // Since these tests may run in parallel, ensure this port is unique to this file
 const servePort = 4502;
@@ -3708,7 +3710,7 @@ Deno.test(
 // TODO(mmastrac): This test should eventually use fetch, when we support trailers there.
 // This test is ignored because it's flaky and relies on cURL's verbose output.
 Deno.test(
-  { permissions: { net: true, run: true, read: true }, ignore: true },
+  { permissions: { net: true, run: true, read: true }, ignore: false },
   async function httpServerTrailers() {
     const ac = new AbortController();
     const { resolve } = Promise.withResolvers<void>();
@@ -3793,32 +3795,6 @@ Deno.test(
   },
 );
 
-async function curlRequest(args: string[]) {
-  const { success, stdout, stderr } = await new Deno.Command("curl", {
-    args,
-    stdout: "piped",
-    stderr: "piped",
-  }).output();
-  assert(
-    success,
-    `Failed to cURL ${args}: stdout\n\n${stdout}\n\nstderr:\n\n${stderr}`,
-  );
-  return new TextDecoder().decode(stdout);
-}
-
-async function curlRequestWithStdErr(args: string[]) {
-  const { success, stdout, stderr } = await new Deno.Command("curl", {
-    args,
-    stdout: "piped",
-    stderr: "piped",
-  }).output();
-  assert(
-    success,
-    `Failed to cURL ${args}: stdout\n\n${stdout}\n\nstderr:\n\n${stderr}`,
-  );
-  return [new TextDecoder().decode(stdout), new TextDecoder().decode(stderr)];
-}
-
 Deno.test("Deno.HttpServer is not thenable", async () => {
   // deno-lint-ignore require-await
   async function serveTest() {

tests/unit/symlink_test.ts

@@ -4,7 +4,7 @@ import {
   assertRejects,
   assertThrows,
   pathToAbsoluteFileUrl,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test(
   { permissions: { read: true, write: true } },

tests/unit/tls_test.ts

@@ -6,7 +6,7 @@ import {
   assertRejects,
   assertStrictEquals,
   assertThrows,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 import { BufReader, BufWriter } from "@std/io/mod.ts";
 import { readAll } from "@std/streams/read_all.ts";
 import { writeAll } from "@std/streams/write_all.ts";

tests/unit/write_file_test.ts

@@ -5,7 +5,7 @@ import {
   assertRejects,
   assertThrows,
   unreachable,
-} from "./test_util.ts";
+} from "../util/test_util.ts";
 
 Deno.test(
   { permissions: { read: true, write: true } },

tests/unit_node/dgram_test.ts

@@ -1,7 +1,7 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
 import { assertEquals } from "@std/assert/mod.ts";
-import { execCode } from "../unit/test_util.ts";
+import { execCode } from "../util/test_util.ts";
 import { createSocket } from "node:dgram";
 
 const listenPort = 4503;

tests/unit_node/fs_test.ts

@@ -12,7 +12,7 @@ import {
   writeFileSync,
 } from "node:fs";
 import { constants as fsPromiseConstants, cp } from "node:fs/promises";
-import { pathToAbsoluteFileUrl } from "../unit/test_util.ts";
+import { pathToAbsoluteFileUrl } from "../util/test_util.ts";
 
 Deno.test(
   "[node/fs writeFileSync] write file without option",

tests/unit_node/http2_test.ts

@@ -3,6 +3,7 @@
 import * as http2 from "node:http2";
 import * as net from "node:net";
 import { assert, assertEquals } from "@std/assert/mod.ts";
+import { curlRequest } from "../util/test_util.ts";
 
 for (const url of ["http://127.0.0.1:4246", "https://127.0.0.1:4247"]) {
   Deno.test(`[node/http2 client] ${url}`, {
@@ -165,3 +166,23 @@ Deno.test("[node/http2 client GET https://www.example.com]", async () => {
   assertEquals(status, 200);
   assert(chunk.length > 0);
 });
+
+Deno.test("[node/http2.createServer()]", { sanitizeOps: false }, async () => {
+  const server = http2.createServer((_req, res) => {
+    res.setHeader("Content-Type", "text/html");
+    res.setHeader("X-Foo", "bar");
+    res.writeHead(200, { "Content-Type": "text/plain; charset=utf-8" });
+    res.write("Hello, World!");
+    res.end();
+  });
+  server.listen(0);
+  const port = (<net.AddressInfo> server.address()).port;
+  const endpoint = `http://localhost:${port}`;
+
+  const response = await curlRequest([
+    endpoint,
+    "--http2-prior-knowledge",
+  ]);
+  assertEquals(response, "Hello, World!");
+  server.close();
+});

tests/unit_node/http_test.ts

@@ -10,7 +10,7 @@ import { assertSpyCalls, spy } from "@std/testing/mock.ts";
 import { gzip } from "node:zlib";
 import { Buffer } from "node:buffer";
 import { serve } from "@std/http/server.ts";
-import { execCode } from "../unit/test_util.ts";
+import { execCode } from "../util/test_util.ts";
 
 Deno.test("[node/http listen]", async () => {
   {

tests/unit/test_util.ts → tests/util/test_util.ts

@@ -1,6 +1,7 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
 import * as colors from "@std/fmt/colors.ts";
+import { assert } from "@std/assert/mod.ts";
 export { colors };
 import { join, resolve } from "@std/path/mod.ts";
 export {
@@ -85,3 +86,35 @@ export function tmpUnixSocketPath(): string {
   const folder = Deno.makeTempDirSync();
   return join(folder, "socket");
 }
+
+export async function curlRequest(args: string[]) {
+  const { success, stdout, stderr } = await new Deno.Command("curl", {
+    args,
+    stdout: "piped",
+    stderr: "piped",
+  }).output();
+  const decoder = new TextDecoder();
+  assert(
+    success,
+    `Failed to cURL ${args}: stdout\n\n${
+      decoder.decode(stdout)
+    }\n\nstderr:\n\n${decoder.decode(stderr)}`,
+  );
+  return decoder.decode(stdout);
+}
+
+export async function curlRequestWithStdErr(args: string[]) {
+  const { success, stdout, stderr } = await new Deno.Command("curl", {
+    args,
+    stdout: "piped",
+    stderr: "piped",
+  }).output();
+  const decoder = new TextDecoder();
+  assert(
+    success,
+    `Failed to cURL ${args}: stdout\n\n${
+      decoder.decode(stdout)
+    }\n\nstderr:\n\n${decoder.decode(stderr)}`,
+  );
+  return [decoder.decode(stdout), decoder.decode(stderr)];
+}