feat(unstable/pm): support npm packages in 'deno add' #22715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Mar 6, 2024
| .map_err(|_| anyhow!("Custom jsr URL cannot be a base."))? | ||
| .pop_if_empty() | ||
| .push("packages"); | ||
| let mut search_url = jsr_api_url().join("packages")?; |
Comment on lines
+219
to
+223
| let range_symbol = if req.version_req.version_text().starts_with('~') { | ||
| '~' | ||
| } else { | ||
| '^' | ||
| }; |
There was a problem hiding this comment.
TIOLI: factor out to a common function to remove duplication?
|
Please land with |
nayeemrmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the cache for npm package metadata endpoints from
$DENO_DIR/registriesto the normal http cache like we use for jsr. It's slightly more convenient.