Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): silence warnings for sloppy imports and node builtins with env var #22760

Merged

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 6, 2024

An undocumented "DENO_DISABLE_PEDANTIC_NODE_WARNINGS" env
var can be used to silence warnings for sloppy imports and node builtins
without node: prefix.

@bartlomieju bartlomieju changed the title fix(publish): allow to enable sloppy imports and node builtins with env var fix(publish): silence warnings for sloppy imports and node builtins with env var Mar 7, 2024
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

cli/resolver.rs Show resolved Hide resolved
@bartlomieju bartlomieju merged commit f0ec4fe into denoland:main Mar 7, 2024
17 checks passed
@bartlomieju bartlomieju deleted the publish_enable_sloppy_with_env_Var branch March 7, 2024 14:16
littledivy pushed a commit that referenced this pull request Mar 8, 2024
…ith env var (#22760)

An undocumented "DENO_DISABLE_PEDANTIC_NODE_WARNINGS" env
var can be used to silence warnings for sloppy imports and node builtins
without `node:` prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants