feat(ext/node): ref/unref on workers #22778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mmastrac
changed the title
bartlomieju
reviewed
Mar 7, 2024
| @@ -128,6 +141,30 @@ class Worker extends EventTarget { | |||
| this.#pollMessages(); | |||
| } | |||
|
|
|||
| [privateWorkerRef](ref) { | |||
There was a problem hiding this comment.
Maybe we could make this property non-enumerable?
bartlomieju
approved these changes
Mar 8, 2024
littledivy
pushed a commit
that referenced
this pull request
Mar 8, 2024
Implements ref/unref on worker to fix part of #22629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ref/unref on worker to fix part of #22629