Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): include explicitly specified .gitignored files and directories #22790

Merged
merged 3 commits into from Mar 8, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 8, 2024

This allows explicitly overriding a .gitignore by specifying files and directories in "include". This does not apply to globs in an include as files matching those will still be gitignored. Additionally, individually gitignored files within an included directory will still be ignored (those can be opted out of being excluded by using a negated glob).

@dsherret dsherret requested a review from littledivy March 8, 2024 04:51
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret changed the title fix(publish): include explicitly specified .gitignored files fix(publish): include explicitly specified .gitignored files and directories Mar 8, 2024
@dsherret dsherret enabled auto-merge (squash) March 8, 2024 05:20
@dsherret dsherret merged commit 40089b3 into denoland:main Mar 8, 2024
17 checks passed
littledivy pushed a commit that referenced this pull request Mar 8, 2024
…ctories (#22790)

This allows explicitly overriding a .gitignore by specifying files and
directories in "include". This does not apply to globs in an include as
files matching those will still be gitignored. Additionally,
individually gitignored files within an included directory will still be
ignored.
@dsherret dsherret deleted the fix_publish_included_files branch March 10, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants