fix: support sloppy resolution to file where directory exists #22800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the sloppy resolver could not resolve the following: - foo/bar.ts - foo.ts - index.ts Where `index.ts` contains `import "./foo"`, because it did not consider `foo.ts` a valid target for this directory import. This commit fixes this bug.
marvinhagemeister
approved these changes
Mar 8, 2024
dsherret
approved these changes
Mar 8, 2024
| probe_paths.push(( | ||
| path.join("index.jsx"), | ||
| SloppyImportsResolutionReason::Directory, | ||
| )); |
There was a problem hiding this comment.
We should probably eventually switch this to an iterator.
There was a problem hiding this comment.
Yup - this could all use a cleanup I agree
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Previously the sloppy resolver could not resolve the following: - foo/bar.ts - foo.ts - index.ts Where `index.ts` contains `import "./foo"`, because it did not consider `foo.ts` a valid target for this directory import. This commit fixes this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the sloppy resolver could not resolve the following:
Where
index.tscontainsimport "./foo", because it did not considerfoo.tsa valid target for this directory import.This commit fixes this bug.