Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): suggest using --allow-dirty on uncommitted changes #22810

Merged
merged 1 commit into from Mar 8, 2024
Merged

fix(publish): suggest using --allow-dirty on uncommitted changes #22810

merged 1 commit into from Mar 8, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 8, 2024

No description provided.

@dsherret dsherret enabled auto-merge (squash) March 8, 2024 22:47
@dsherret dsherret merged commit 119744c into denoland:main Mar 8, 2024
17 checks passed
nathanwhit pushed a commit that referenced this pull request Mar 14, 2024
@dsherret @nathanwhit
fix(publish): suggest using --allow-dirty on uncommitted changes (#…
4999834 
…22810)
@iuioiua
Copy link
Collaborator

iuioiua commented Mar 15, 2024

The purpose of --allow-dirty doesn't seem immediately obvious. I would've suggested --allow-uncommitted instead.

@bartlomieju
Copy link
Member

The purpose of --allow-dirty doesn't seem immediately obvious. I would've suggested --allow-uncommitted instead.

We used the same approach as Cargo is using.

@iuioiua
Copy link
Collaborator

iuioiua commented Mar 15, 2024

Then I think Cargo should change the name of their flag, too 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @iuioiua @bartlomieju