Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove pkg name example and add pattern to schema #22813

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 8, 2024

I was typing in my package name in a deno.json and got confused when it did this suggestion.

image

Probably best to remove the example and instead replace it with a pattern.

@dsherret dsherret changed the title fix(config): make package name example instructional fix(config): remove pkg name example and add pattern to schema Mar 8, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@dsherret dsherret enabled auto-merge (squash) March 8, 2024 22:52
@dsherret dsherret merged commit 58c28d9 into denoland:main Mar 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants