fix(ext/node): make worker setup synchronous #22815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Mar 8, 2024
satyarohith
changed the title
mmastrac
reviewed
Mar 11, 2024
mmastrac
approved these changes
Mar 11, 2024
bartlomieju
added a commit
that referenced
this pull request
Mar 11, 2024
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
This commit fixes race condition in "node:worker_threads" module were the first message did a setup of "threadId", "workerData" and "environmentData". Now this data is passed explicitly during workers creation and is set up before any user code is executed. Closes #22783 Closes #22672 --------- Co-authored-by: Satya Rohith <me@satyarohith.com>
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes race condition in "node:worker_threads" module were
the first message did a setup of "threadId", "workerData" and "environmentData".
Now this data is passed explicitly during workers creation and is set up
before any user code is executed.
Closes #22783
Closes #22672