Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): Match punycode module behavior to node #22847

Merged
merged 7 commits into from
Mar 11, 2024
Merged

fix(ext/node): Match punycode module behavior to node #22847

merged 7 commits into from
Mar 11, 2024

Commits on Mar 11, 2024

  1. Match node.js punycode behavior

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    66db4a0 View commit details
    Browse the repository at this point in the history

  2. Make punycode polyfill match node behavior

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9772aca View commit details
    Browse the repository at this point in the history

  3. Emit deprecated warning for using punycode polyfill

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8a3607f View commit details
    Browse the repository at this point in the history

  4. Enable punycode node_compat test

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    711923b View commit details
    Browse the repository at this point in the history

  5. Add regression test

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cef2582 View commit details
    Browse the repository at this point in the history

  6. Appease linter

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    864dfc4 View commit details
    Browse the repository at this point in the history

  7. Fork toASCII/toUnicode into node compat and idna compat ops

    @nathanwhit
    nathanwhit committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    da1f178 View commit details
    Browse the repository at this point in the history