feat(node): implement fs.statfs() #22862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Mar 12, 2024
littledivy
reviewed
Mar 12, 2024
bartlomieju
approved these changes
Mar 13, 2024
| @@ -12,6 +12,7 @@ export const ArrayPrototypeSlice = (that, ...args) => that.slice(...args); | |||
| export const ArrayPrototypeSome = (that, ...args) => that.some(...args); | |||
| export const ArrayPrototypeSort = (that, ...args) => that.sort(...args); | |||
| export const ArrayPrototypeUnshift = (that, ...args) => that.unshift(...args); | |||
| export const BigInt = globalThis.BigInt; | |||
There was a problem hiding this comment.
Is BigInt not available in primordials from ext:core/mod.js? If so we should fix it 😬
littledivy
reviewed
Mar 13, 2024
ext/node/ops/fs.rs
Outdated
Comment on lines
177
to
178
| #[allow(clippy::disallowed_methods)] | ||
| let path = Path::new("Cargo.toml").canonicalize().unwrap(); |
There was a problem hiding this comment.
Wouldn't canonicalize() fail if Cargo.toml is not present?
There was a problem hiding this comment.
I'm not sure why we need this. The user path argument is shadowed by this hardcoded path to Cargo.toml
There was a problem hiding this comment.
I must have copy-pasted this from my windows playground repo... that's frustrating there was no lint error.
magurotuna
pushed a commit
to magurotuna/deno
that referenced
this pull request
Mar 13, 2024
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21139.