Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/node): add support for named curves in crypto.generateKeyPair[Sync]() #22882

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat(ext/node): add support for named curves in crypto.generateKeyPair[Sync]() #22882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2825f4
fix(ext/node): add support for `prime256v1` named curve in `crypto.ge…
iuioiua Mar 13, 2024
98d8372
add more names
iuioiua Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions ext/node/ops/crypto/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,8 +707,12 @@ fn ec_generate(
use ring::signature::KeyPair;

let curve = match named_curve {
"P-256" => &ring::signature::ECDSA_P256_SHA256_FIXED_SIGNING,
"P-384" => &ring::signature::ECDSA_P384_SHA384_FIXED_SIGNING,
"P-256" | "prime256v1" | "secp256r1" => {
&ring::signature::ECDSA_P256_SHA256_FIXED_SIGNING
}
"P-384" | "prime384v1" | "secp384r1" => {
&ring::signature::ECDSA_P384_SHA384_FIXED_SIGNING
}
_ => return Err(type_error("Unsupported named curve")),
};

Expand Down
11 changes: 10 additions & 1 deletion tests/unit_node/crypto/crypto_key_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,16 @@ for (const type of ["rsa", "rsa-pss", "dsa"]) {
}
}

for (const namedCurve of ["P-384", "P-256"]) {
for (
const namedCurve of [
"P-384",
"prime384v1",
"secp384r1",
"P-256",
"prime256v1",
"secp256r1",
]
) {
Deno.test({
name: `generate ec key ${namedCurve}`,
fn() {
Expand Down