Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle cache body file not existing when using etag #22931

Merged
merged 1 commit into from Mar 15, 2024

Conversation

dsherret
Copy link
Member

Removes this unwrap:

> ../deno/target/debug/deno install -Afr jsr:@deno/deployctl
Loading: https://jsr.io/@deno/deployctl/meta.json ReloadAll
NOT MODIFIED: https://jsr.io/@deno/deployctl/meta.json

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: windows x86_64
Version: 1.41.2
Args: ["V:\\deno\\target\\debug\\deno.exe", "install", "-Afr", "jsr:@deno/deployctl"]

thread 'main' panicked at cli\file_fetcher.rs:394:16:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. But you should stop messing with your local cache 🥲🤣

@dsherret dsherret merged commit 36e6e4a into denoland:main Mar 15, 2024
17 checks passed
@dsherret dsherret deleted the fix_etag_unwrap branch March 15, 2024 13:57
dsherret added a commit to dsherret/deno that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants