Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): worker_threads doesn't exit if there are message listeners #22944

Merged
merged 9 commits into from Mar 15, 2024
Merged

fix(ext/node): worker_threads doesn't exit if there are message listeners #22944

merged 9 commits into from Mar 15, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 15, 2024 •
edited

Closes #22934

@mash-graz
Copy link
Contributor

This looks like the way it should work! :)

mmastrac
mmastrac approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmastrac
mmastrac reviewed Mar 15, 2024
View reviewed changes
runtime/web_worker.rs Outdated Show resolved Hide resolved
mmastrac
mmastrac approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit c342cd3 into denoland:main Mar 15, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_worker_thread branch March 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@satyarohith satyarohith Awaiting requested review from satyarohith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:worker_threads exits too early
3 participants
@bartlomieju @mash-graz @mmastrac