Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): support MessagePort in WorkerOptions.workerData #22950

Merged
merged 7 commits into from Mar 16, 2024

Conversation

bartlomieju
Copy link
Member

This commit fixes passing MessagePort instances to WorkerOptions.workerData.
Before they were not serialized and deserialized properly when spawning a worker
thread.

Closes #22935

Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 92576fd into denoland:main Mar 16, 2024
17 checks passed
@bartlomieju bartlomieju deleted the ext_node_worker_workerdata branch March 16, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node:worker_threads doesn't support MessagePort in workerData
2 participants