Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): implement v8 serialize and deserialize #22975

Merged
merged 1 commit into from Mar 18, 2024
Merged

fix(node): implement v8 serialize and deserialize #22975

merged 1 commit into from Mar 18, 2024

Conversation

littledivy
Copy link
Member

Fixes #22971

satyarohith
satyarohith approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit bd6938a into denoland:main Mar 18, 2024
17 checks passed
@littledivy littledivy deleted the v8_serialize branch March 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v8.serialize not implemented for node:v8
2 participants
@littledivy @satyarohith